Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate all the missing Gio bindings #1587

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Generate all the missing Gio bindings #1587

merged 1 commit into from
Dec 2, 2024

Conversation

bilelmoussaoui
Copy link
Member

Only the ones that can be generated now without requiring any manual implementations.

Closes #1586

sdroege
sdroege previously approved these changes Dec 1, 2024
View reviewed changes
@sdroege
Copy link
Member

sdroege commented Dec 1, 2024

Looks good to me except for the build failure. Thanks :)

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gio-bindings branch from 39c9136 to 2cd342d Compare December 1, 2024 16:49
@bilelmoussaoui
Copy link
Member Author

Looks good to me except for the build failure. Thanks :)

Fixed. Weird that the windows job failed with

  = note: libgio-7dc3770705388690.rlib(gio-7dc3770705388690.8o5fjhfbaf10yz7o7kdcyhib7.rcgu.o) : error LNK2019: unresolved external symbol g_io_module_load referenced in function _ZN3gio4auto9io_module8IOModule4load17h8e61cc193a091eb3E␍
          libgio-7dc3770705388690.rlib(gio-7dc3770705388690.8o5fjhfbaf10yz7o7kdcyhib7.rcgu.o) : error LNK2019: unresolved external symbol g_io_module_unload referenced in function _ZN3gio4auto9io_module8IOModule6unload17hf6c0a2d14e6415cdE␍
          libgio-7dc3770705388690.rlib(gio-7dc3770705388690.8o5fjhfbaf10yz7o7kdcyhib7.rcgu.o) : error LNK2019: unresolved external symbol g_io_module_query referenced in function

As far as I know, GIOModule is supposed to work on also windows, no? anyways, dropped it from this PR

@bilelmoussaoui
Generate all the missing Gio bindings
059efb0 
Only the ones that can be generated now without requiring any manual
implementations.
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/gio-bindings branch from 2cd342d to 059efb0 Compare December 1, 2024 16:53
@sdroege sdroege merged commit 94435b2 into main Dec 2, 2024
48 checks passed
@sdroege sdroege deleted the bilelmoussaoui/gio-bindings branch December 2, 2024 07:46
@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Dec 2, 2024
@sdroege sdroege removed the needs-backport PR needs backporting to the current stable branch label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find TcpWrapperConnection
2 participants
@bilelmoussaoui @sdroege